Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cypress config to new layer template #736

Merged
merged 7 commits into from
Aug 1, 2023
Merged

Conversation

dylankelly
Copy link
Contributor

Issue:

What I did

  • Add ripple cypress config as Cypress plugin
  • Update new layer CLI template

How to test

  • pnpm build
  • pnpm -F nuxt-ripple-cli nuxt-ripple init layer /path/to/your/layer --name layer-name --gitHubActions

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@codesandbox
Copy link

codesandbox bot commented Aug 1, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@netlify
Copy link

netlify bot commented Aug 1, 2023

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 178f07a
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/64c8d94e89fda000084cc6c7

@cypress
Copy link

cypress bot commented Aug 1, 2023

Passing run #143 ↗︎

0 83 0 0 Flakiness 0

Details:

Merge branch 'feature/update-cli' of github.com:dpc-sdp/ripple-framework into fe...
Project: ripple-framework Commit: 1a972939be
Status: Passed Duration: 03:01 💡
Started: Aug 1, 2023 10:52 AM Ended: Aug 1, 2023 10:55 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@dylankelly
Copy link
Contributor Author

merging this unreviewed as it needs to be published in order for layer updates to work

@dylankelly dylankelly merged commit faf1172 into develop Aug 1, 2023
7 checks passed
@dylankelly dylankelly added this to the 2.1.0 milestone Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant