Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/maps search bar #949

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Feature/maps search bar #949

merged 3 commits into from
Dec 6, 2023

Conversation

jeffdowdle
Copy link
Contributor

Issue:

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@jeffdowdle jeffdowdle self-assigned this Dec 6, 2023
@dylankelly dylankelly force-pushed the maps-integreation branch 2 times, most recently from 60e63b1 to 3b26eb7 Compare December 6, 2023 12:18
@cypress Cypress
Copy link

cypress bot commented Dec 6, 2023

1 failed test on run #975 ↗︎

1 100 4 0 Flakiness 0

Details:

Merge branch 'maps-integreation' into feature/maps-search-bar
Project: ripple-framework Commit: 1a933da70d
Status: Failed Duration: 04:21 💡
Started: Dec 6, 2023 10:59 PM Ended: Dec 6, 2023 11:03 PM
Failed  test/features/maps/vsba.feature • 1 failed test

View Output Video

Test Artifacts
School buildings map > Search for postcode Screenshots Video

Review all test suite changes for PR #949 ↗︎

@jeffdowdle jeffdowdle merged commit c190368 into maps-integreation Dec 6, 2023
6 of 10 checks passed
@jeffdowdle jeffdowdle deleted the feature/maps-search-bar branch December 6, 2023 23:05
@cypress cypress bot mentioned this pull request Dec 6, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday Awaiting requested review from waitingallday

@dylankelly dylankelly Awaiting requested review from dylankelly

Assignees

@jeffdowdle jeffdowdle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jeffdowdle