Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-1604] Add date to news card #956

Merged
merged 3 commits into from
Dec 18, 2023
Merged

[R20-1604] Add date to news card #956

merged 3 commits into from
Dec 18, 2023

Conversation

waitingallday
Copy link
Member

Issue: https://digital-vic.atlassian.net/browse/R20-1604

What I did

  • Add publish date to TideSearchResultCard by default where field_news_date exists
  • Added sample fixture

How to test

  • Cypress

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@waitingallday waitingallday self-assigned this Dec 8, 2023
@netlify Netlify
Copy link

netlify bot commented Dec 8, 2023 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 36439c6
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/657805ce58f38a0008e9b0d5

@cypress Cypress
Copy link

cypress bot commented Dec 12, 2023

Passing run #1014 ↗︎

0 102 0 0 Flakiness 0

Details:

Merge branch 'develop' into feat/r20-1604-promo-card-date
Project: ripple-framework Commit: 36439c66bc
Status: Passed Duration: 04:13 💡
Started: Dec 12, 2023 7:06 AM Ended: Dec 12, 2023 7:10 AM

Review all test suite changes for PR #956 ↗︎

@waitingallday waitingallday added this pull request to the merge queue Dec 18, 2023
Merged via the queue into develop with commit 47c0469 Dec 18, 2023
8 checks passed
@waitingallday waitingallday deleted the feat/r20-1604-promo-card-date branch December 18, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle jeffdowdle approved these changes

Assignees

@waitingallday waitingallday

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waitingallday @dylankelly @jeffdowdle