Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-1644] added missing scroll wrapper for wysiwg tables #957

Merged
merged 1 commit into from
Dec 11, 2023
Merged

[R20-1644] added missing scroll wrapper for wysiwg tables #957

merged 1 commit into from
Dec 11, 2023

Conversation

jeffdowdle
Copy link
Contributor

Old
Screenshot 2023-12-11 at 1 45 49 pm

New
Screenshot 2023-12-11 at 1 45 56 pm

Issue: https://digital-vic.atlassian.net/browse/R20-1644

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@jeffdowdle jeffdowdle self-assigned this Dec 11, 2023
@netlify Netlify
Copy link

netlify bot commented Dec 11, 2023 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 3a3a48c
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/6576794277f87c00084a20cb

@cypress Cypress
Copy link

cypress bot commented Dec 11, 2023

Passing run #1002 ↗︎

0 101 0 0 Flakiness 0

Details:

fix(@dpc-sdp/ripple-ui-core): added missing scroll wrapper for wysiwg tables
Project: ripple-framework Commit: 3a3a48cbf6
Status: Passed Duration: 03:48 💡
Started: Dec 11, 2023 2:52 AM Ended: Dec 11, 2023 2:56 AM

Review all test suite changes for PR #957 ↗︎

@dylankelly dylankelly added this pull request to the merge queue Dec 11, 2023
Merged via the queue into develop with commit dfc2395 Dec 11, 2023
8 checks passed
@dylankelly dylankelly deleted the bugfix/R20-1644 branch December 11, 2023 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly dylankelly approved these changes

Assignees

@jeffdowdle jeffdowdle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffdowdle @waitingallday @dylankelly