Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-1678] add clear search event #971

Merged
merged 3 commits into from
Jan 8, 2024
Merged

[R20-1678] add clear search event #971

merged 3 commits into from
Jan 8, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Dec 26, 2023

Issue: https://digital-vic.atlassian.net/browse/R20-1678

What I did

  • Add bespoke clear filters event for search, search listing and custom collection; this is instead of falling back to the form reset event.

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@netlify Netlify
Copy link

netlify bot commented Dec 26, 2023 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 2de005a
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/659b73e87e8e8d0008071518

@cypress Cypress
Copy link

cypress bot commented Dec 26, 2023 •
edited
Loading

Passing run #1081 ↗︎

0 109 0 0 Flakiness 0

Details:

Merge branch 'develop' into feature/R20-1678-clear-search-event
Project: ripple-framework Commit: 2de005a642
Status: Passed Duration: 05:33 💡
Started: Jan 8, 2024 4:05 AM Ended: Jan 8, 2024 4:11 AM

Review all test suite changes for PR #971 ↗︎

@lambry lambry self-assigned this Dec 27, 2023
Merge branch 'develop' into feature/R20-1678-clear-search-event
2de005a 
# Conflicts:
#	packages/ripple-tide-search/components/TideSearchFilters.vue
@lambry lambry marked this pull request as ready for review January 8, 2024 04:56
@dylankelly dylankelly added this pull request to the merge queue Jan 8, 2024
Merged via the queue into develop with commit 20b531f Jan 8, 2024
15 of 16 checks passed
@dylankelly dylankelly deleted the feature/R20-1678-clear-search-event branch January 8, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly dylankelly approved these changes

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @waitingallday @dylankelly