Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-1701] Dependent filters support #978

Merged
merged 6 commits into from
Jan 12, 2024
Merged

Conversation

dylankelly
Copy link
Contributor

@dylankelly dylankelly commented Jan 3, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-1701

What I did

  • This adds support for dependent filters i.e select x from the parent dropdown then the child dropdown updates to show children of x

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

Copy link

netlify bot commented Jan 3, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 0603182
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/65a0b9e957b5430008bf84d9

Copy link

cypress bot commented Jan 8, 2024

Passing run #1115 ↗︎

0 112 0 0 Flakiness 0

Details:

fix(@dpc-sdp/ripple-tide-search): ✅ fix failing dependent filte...
Project: ripple-framework Commit: 0603182bae
Status: Passed Duration: 05:39 💡
Started: Jan 12, 2024 4:05 AM Ended: Jan 12, 2024 4:11 AM

Review all test suite changes for PR #978 ↗︎

@lambry lambry changed the title Feature/filter hierarchy [R20-1701] Dependent filters support Jan 11, 2024
@dylankelly dylankelly marked this pull request as ready for review January 12, 2024 04:05
@dylankelly dylankelly merged commit 200afb8 into develop Jan 12, 2024
16 checks passed
@dylankelly dylankelly deleted the feature/filter-hierarchy branch January 12, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant