Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-1730] Fixed icon not changing when exiting fullscreen map via keyboard #993

Merged
merged 1 commit into from
Jan 21, 2024
Merged

[R20-1730] Fixed icon not changing when exiting fullscreen map via keyboard #993

merged 1 commit into from
Jan 21, 2024

Conversation

jeffdowdle
Copy link
Contributor

Issue: https://digital-vic.atlassian.net/browse/R20-1730

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@jeffdowdle jeffdowdle self-assigned this Jan 18, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 18, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 3e79adc
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/65a9a9747b923e00087ba84d

@cypress Cypress
Copy link

cypress bot commented Jan 18, 2024

Passing run #1148 ↗︎

0 116 0 0 Flakiness 0

Details:

fix(@dpc-sdp/ripple-ui-maps): fixed icon not changing when exiting fullscreen ma...
Project: ripple-framework Commit: 3e79adc3a1
Status: Passed Duration: 05:59 💡
Started: Jan 18, 2024 10:44 PM Ended: Jan 18, 2024 10:50 PM

Review all test suite changes for PR #993 ↗︎

@waitingallday waitingallday added this pull request to the merge queue Jan 21, 2024
Merged via the queue into develop with commit 0ff6b3a Jan 21, 2024
8 checks passed
@waitingallday waitingallday deleted the bugfix/R20-1730 branch January 21, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambry lambry lambry approved these changes

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly Awaiting requested review from dylankelly

Assignees

@jeffdowdle jeffdowdle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffdowdle @lambry @waitingallday