[SDPTA-1159] Revert changes causing content-vic performance issue

tide_demo_content.install

@@ -79,7 +79,7 @@ function tide_demo_content_install() {
     $department = [1459];
     /** @var \Drupal\tide_site\TideSiteHelper $site_helper */
     $site_helper = \Drupal::service('tide_site.helper');
-    $sites = _tide_demo_content_get_all_sections();
+    $sites = $site_helper->getAllSites();
     $user_ids = \Drupal::entityQuery('user')
       ->condition('name', $usernames, 'IN')
       ->sort('uid', 'ASC')
@@ -115,25 +115,3 @@ function tide_demo_content_uninstall() {
   $repository->removeTrackedEntities();
   \Drupal::messenger()->addMessage('Removed all demo content.');
 }
-
-/**
- * Get all sites and site sections.
- */
-function _tide_demo_content_get_all_sections() {
-  $sites = [];
-
-  try {
-
-    $terms = \Drupal::entityTypeManager()->getStorage('taxonomy_term')
-      ->loadByProperties(['vid' => 'sites']);
-
-    foreach ($terms as $site) {
-      $sites[$site->id()] = $site;
-    }
-  }
-  catch (\Exception $exception) {
-    watchdog_exception('tide_site', $exception);
-  }
-
-  return $sites;
-}