Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

added config field and hook #156

Merged
merged 11 commits into from
Jul 22, 2024

Conversation

yeniatencio
Copy link
Contributor

@yeniatencio yeniatencio commented Jun 27, 2024

Ticket: https://digital-vic.atlassian.net/browse/SDPAP-9240

BE testing link: https://nginx-php.pr-408.content-reference-sdp-vic-gov-au.sdp4.sdp.vic.gov.au/

Steps:

  1. Added new field in the site taxonomy.
  2. Add an update hook to roll out the updates for existing site.
  3. Updated behat test.
  4. Dev-tools commit hash to avoid behat test failing. (Will remove it once this pr is approved)

Screenshot 2024-07-01 at 11 36 30 am

Copy link
Contributor

@anthony-malkoun anthony-malkoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @yeniatencio. One thing I'd like to see us get into the habit of (or maybe automate somehow) is having this run against a couple of different sites so we know the hook runs ok. But that's for future Yeni :)

@yeniatencio yeniatencio merged commit d135c39 into develop Jul 22, 2024
4 of 6 checks passed
@yeniatencio yeniatencio deleted the feature/SDPAP-9240-content-rating-form branch July 22, 2024 07:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants