Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add immediate observer callback invokation #209

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Add immediate observer callback invokation #209

merged 2 commits into from
Feb 1, 2023

Conversation

krypt102
Copy link
Contributor

@krypt102 krypt102 commented Feb 1, 2023

Fixes #166
Basically just runs the callback immediately while still providing a disconnect function.
Will be a draft for the moment until I implement disconnecting

@krypt102 krypt102 marked this pull request as draft February 1, 2023 05:02
@krypt102 krypt102 marked this pull request as ready for review February 1, 2023 05:05
@krypt102
Copy link
Contributor Author

krypt102 commented Feb 1, 2023

Nevermind, that was surprisingly easier than I thought

@dphfox dphfox added ready to work on Enhancements/changes ready to be made area: state not ready - blocked Waiting on other work to be done and removed ready to work on Enhancements/changes ready to be made not ready - blocked Waiting on other work to be done labels Feb 1, 2023
@dphfox
Copy link
Owner

dphfox commented Feb 1, 2023

Looks good to me :)

@dphfox dphfox merged commit b62d7e7 into dphfox:main Feb 1, 2023
@dphfox dphfox mentioned this pull request Feb 1, 2023
@krypt102 krypt102 deleted the immediate-observer-invokation branch February 1, 2023 20:46
@Dionysusnu
Copy link
Contributor

Solves #166

FYI, if you replace "Solves" with fixes or closes, GitHub will automatically close the linked issue when a Pull Request is merged into the main branch.

For example: "closes #166"

https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

@krypt102
Copy link
Contributor Author

krypt102 commented Feb 3, 2023

Solves #166

FYI, if you replace "Solves" with fixes or closes, GitHub will automatically close the linked issue when a Pull Request is merged into the main branch.

For example: "closes #166"

https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

Ohhhh, thank you! That's why it wasn't showing before 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to work on Enhancements/changes ready to be made
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Allow immediate invokation for Observer:onChange()
3 participants