Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to additional_target_cpus #64

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Conversation

sdefresne
Copy link
Contributor

This parameter will be removed from Chromium build system. While this is just a meaningless key in a sample json file used for performance testing, the project is cloned into Chromium and the string "additional_target_cpus" shows up when doing search in the codebase of Chromium.

Removing the line from the sample should change too much the validity of the performance testing, but it would simplify the effort of removing the additional_target_cpus parameter from Chromium build system as this would remove false positive when searching the codebase.

Reference: https://crbug.com/1337780

This parameter will be removed from Chromium build system. While
this is just a meaningless key in a sample json file used for
performance testing, the project is cloned into Chromium and the
string "additional_target_cpus" shows up when doing search in
the codebase of Chromium.

Removing the line from the sample should change too much the
validity of the performance testing, but it would simplify the
effort of removing the additional_target_cpus parameter from
Chromium build system as this would remove false positive when
searching the codebase.

Reference: https://crbug.com/1337780
@dpranke
Copy link
Owner

dpranke commented Mar 16, 2023

Looks good. Thanks for the change!

@dpranke dpranke merged commit e47b861 into dpranke:main Mar 16, 2023
dpranke added a commit that referenced this pull request Mar 16, 2023
* v0.9.13 (2023-03-16)
    * [GitHub PR #64](#64)
      Remove a field from one of the JSON benchmark files to
      reduce confusion in Chromium.
    * No code changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants