Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent prefix semicolon insertion for increment and decrement #648

Merged
merged 2 commits into from
Jul 31, 2024
Merged

fix: prevent prefix semicolon insertion for increment and decrement #648

merged 2 commits into from
Jul 31, 2024

Conversation

yazan-abdalrahman
Copy link
Contributor

@yazan-abdalrahman yazan-abdalrahman commented Jul 10, 2024 •
edited
Loading

fix #24285
#denoland/deno#24285

@CLAassistant
Copy link

CLAassistant commented Jul 10, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@yazan-abdalrahman
Copy link
Contributor Author

@dsherret
can u please review it

@yazan-abdalrahman yazan-abdalrahman mentioned this pull request Jul 10, 2024
Closed
@yazan-abdalrahman
Copy link
Contributor Author

@dsherret ,
please check it

@dsherret dsherret changed the title fix(fmt): Prevent prefix semicolon insertion when no-simecolum flag is set fix(fmt): prevent prefix semicolon insertion for increment and decrement Jul 31, 2024
@dsherret dsherret changed the title fix(fmt): prevent prefix semicolon insertion for increment and decrement fix: prevent prefix semicolon insertion for increment and decrement Jul 31, 2024
dsherret
dsherret approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dsherret dsherret merged commit 1e3583d into dprint:main Jul 31, 2024
2 checks passed
@dsherret dsherret mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yazan-abdalrahman @CLAassistant @dsherret