Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace <select>s with a custom Combobox component #1301

Draft
wants to merge 44 commits into
base: develop
Choose a base branch
from
Draft

Replace <select>s with a custom Combobox component #1301

wants to merge 44 commits into from

Commits on Sep 24, 2024

  1. replace selects with our custom combobox

    @MattBudz
    MattBudz committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    bbfa017 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. add option selection functionality

    @MattBudz
    MattBudz committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    19aba46 View commit details
    Browse the repository at this point in the history

  2. ensure menu width matches the select width

    @MattBudz
    MattBudz committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    c33f3ff View commit details
    Browse the repository at this point in the history

  3. better naming + fix selection on load

    @MattBudz
    MattBudz committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    1067926 View commit details
    Browse the repository at this point in the history

  4. add filtering UI

    @MattBudz
    MattBudz committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    55d1549 View commit details
    Browse the repository at this point in the history

  5. add filtering functionality

    @MattBudz
    MattBudz committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    56cf6e4 View commit details
    Browse the repository at this point in the history

  6. auto-focus on filter if it's present

    @MattBudz
    MattBudz committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    c3b1262 View commit details
    Browse the repository at this point in the history

  7. fix toggleClass condition

    @MattBudz
    MattBudz committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    b1bb48a View commit details
    Browse the repository at this point in the history

  8. clear filter when the menu is closed

    @MattBudz
    MattBudz committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    8d7cf14 View commit details
    Browse the repository at this point in the history

  9. typo

    @MattBudz
    MattBudz committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    911ed3b View commit details
    Browse the repository at this point in the history

  10. semantics

    @MattBudz
    MattBudz committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    1f19cae View commit details
    Browse the repository at this point in the history

  11. fix deboune not working

    @MattBudz
    MattBudz committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    025b188 View commit details
    Browse the repository at this point in the history

  12. add filter results empty state

    @MattBudz
    MattBudz committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    68a47d4 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. add support for <optgroups>s

    @MattBudz
    MattBudz committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    e892f4b View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. update combobox when select is programatically updated

    @MattBudz
    MattBudz committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    8d9bb92 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. add support for multiple options

    @MattBudz
    MattBudz committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    1109db6 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Merge branch 'develop' into combobox/base

    @MattBudz
    MattBudz committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    5b635be View commit details
    Browse the repository at this point in the history

  2. add support for disabled options

    @MattBudz
    MattBudz committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    996a669 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. alpha css

    @MattBudz
    MattBudz committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    fa62ac2 View commit details
    Browse the repository at this point in the history

  2. add support for user defined options

    @MattBudz
    MattBudz committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    c577304 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. improve pro parity and consistency

    @MattBudz
    MattBudz committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    0409fdb View commit details
    Browse the repository at this point in the history

  2. add support for disabled selects

    @MattBudz
    MattBudz committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    607080a View commit details
    Browse the repository at this point in the history

  3. improve disabled styles

    @MattBudz
    MattBudz committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    947a9ec View commit details
    Browse the repository at this point in the history

  4. ensure <select> change eventListeners still work

    @MattBudz
    MattBudz committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    4d8c2ee View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. prevent re-init on existing combobox

    @MattBudz
    MattBudz committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    8918700 View commit details
    Browse the repository at this point in the history

  2. make filtering a default combobox feature

    @MattBudz
    MattBudz committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    ab55a3a View commit details
    Browse the repository at this point in the history

  3. fix prompt option not being re-selectable

    @MattBudz
    MattBudz committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    aef0505 View commit details
    Browse the repository at this point in the history

  4. update style guide

    @MattBudz
    MattBudz committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    5af4f55 View commit details
    Browse the repository at this point in the history

  5. add support for colored options and icons

    @MattBudz
    MattBudz committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    e20195f View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. optimize combobox-option click event binding

    @MattBudz
    MattBudz committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    67bb912 View commit details
    Browse the repository at this point in the history

  2. refactor selectOptions() for readability

    @MattBudz
    MattBudz committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    a885d5d View commit details
    Browse the repository at this point in the history

  3. reduce number of eventlisteners

    @MattBudz
    MattBudz committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    ee9755d View commit details
    Browse the repository at this point in the history

  4. refactor to use ES6 syntax & reduce eventlisteners

    @MattBudz
    MattBudz committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    5db095b View commit details
    Browse the repository at this point in the history

  5. typo

    @MattBudz
    MattBudz committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    1cded74 View commit details
    Browse the repository at this point in the history

  6. improve readability & split init() into functions

    @MattBudz
    MattBudz committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    e7be8ee View commit details
    Browse the repository at this point in the history

  7. remove debugging flag

    @MattBudz
    MattBudz committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    65a8487 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Merge branch 'develop' into combobox/base

    @MattBudz
    MattBudz committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    e135325 View commit details
    Browse the repository at this point in the history

  2. differentiate between hover/focus and selected

    @MattBudz
    MattBudz committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    b5aa323 View commit details
    Browse the repository at this point in the history

  3. avoid hover style collision + improve pro contrast

    @MattBudz
    MattBudz committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    18560db View commit details
    Browse the repository at this point in the history

  4. alpha

    @MattBudz
    MattBudz committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    1e13600 View commit details
    Browse the repository at this point in the history

  5. fix bugs resulting from hiding menu based on focus

    @MattBudz
    MattBudz committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    d716267 View commit details
    Browse the repository at this point in the history

  6. add aria-attributes for accessibility

    @MattBudz
    MattBudz committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    3c6e504 View commit details
    Browse the repository at this point in the history

  7. unselect multi-option if re-selecting

    @MattBudz
    MattBudz committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    3adb339 View commit details
    Browse the repository at this point in the history

  8. fix missing selected class

    @MattBudz
    MattBudz committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    84015bd View commit details
    Browse the repository at this point in the history