Skip to content

Commit

Permalink
fix: failure in test_cluster_fuzzymigration (#3363)
Browse files Browse the repository at this point in the history
  • Loading branch information
romange authored Jul 22, 2024
1 parent f81a893 commit aac90f2
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions tests/dragonfly/cluster_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -1278,7 +1278,6 @@ async def test_network_disconnect_during_migration(df_factory, df_seeder_factory
await close_clients(*[node.client for node in nodes], *[node.admin_client for node in nodes])


@pytest.mark.skip("Fails in CI, TODO: to reenable it")
@pytest.mark.parametrize(
"node_count, segments, keys",
[
Expand Down Expand Up @@ -1373,7 +1372,6 @@ async def list_counter(key, client: aioredis.RedisCluster):

logging.debug("finish migrations")

@assert_eventually(times=500)
async def all_finished():
res = True
for node in nodes:
Expand Down Expand Up @@ -1410,7 +1408,11 @@ async def all_finished():
res = False
return res

await all_finished
@assert_eventually(times=500)
async def test_all_finished():
assert await all_finished()

await test_all_finished()

for counter in counters:
counter.cancel()
Expand Down

0 comments on commit aac90f2

Please sign in to comment.