Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep: upgrade tokio to 1.35.1 #1531

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Conversation

kevinXYin
Copy link
Contributor

@kevinXYin kevinXYin commented Dec 27, 2023

Relevant Issue (if applicable)

#1486

Details

Fix painc after all prefetch worker exit for fscache mode.
I tried to find the root cause for this issue, but I am not familiar with tokio. Anyway
after update tokio this issue does not recur.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@kevinXYin kevinXYin requested a review from a team as a code owner December 27, 2023 02:50
@kevinXYin kevinXYin requested review from imeoer, adamqqqplay and Desiki-high and removed request for a team December 27, 2023 02:50
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f27b7a) 61.29% compared to head (9fb64fe) 61.28%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1531      +/-   ##
==========================================
- Coverage   61.29%   61.28%   -0.02%     
==========================================
  Files         145      145              
  Lines       46617    46617              
  Branches    44153    44153              
==========================================
- Hits        28576    28571       -5     
- Misses      16591    16595       +4     
- Partials     1450     1451       +1     

see 2 files with indirect coverage changes

Fix painc after all prefetch worker exit for fscache mode.

Signed-off-by: Xin Yin <yinxin.x@bytedance.com>
@Desiki-high Desiki-high merged commit cf76edb into dragonflyoss:master Dec 27, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In fscache mode, nydusd panicked after prefetch done.
2 participants