Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: bump 1.72.1 and fix errors #1532

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Conversation

Desiki-high
Copy link
Member

@Desiki-high Desiki-high commented Dec 28, 2023

Relevant Issue (if applicable)

N/A.

Details

Bump rust 1.72.1 and fix errors and warnings.
ref:
https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg
https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
https://rust-lang.github.io/rust-clippy/master/index.html#reserve_after_initializatio
https://rust-lang.github.io/rust-clippy/master/index.html#/arc_with_non_send_sync
https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@Desiki-high Desiki-high requested review from a team as code owners December 28, 2023 01:24
@Desiki-high Desiki-high requested review from bergwolf, liubogithub, gaius-qi and power-more and removed request for a team December 28, 2023 01:24
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (cf76edb) 61.30% compared to head (9ddca59) 61.27%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1532      +/-   ##
==========================================
- Coverage   61.30%   61.27%   -0.04%     
==========================================
  Files         145      144       -1     
  Lines       46617    46597      -20     
  Branches    44153    44133      -20     
==========================================
- Hits        28578    28550      -28     
- Misses      16591    16595       +4     
- Partials     1448     1452       +4     
Files Coverage Δ
api/src/error.rs 67.74% <ø> (ø)
builder/src/core/context.rs 67.03% <100.00%> (ø)
builder/src/core/node.rs 82.47% <100.00%> (ø)
builder/src/core/tree.rs 83.86% <100.00%> (-0.34%) ⬇️
builder/src/core/v6.rs 75.51% <100.00%> (-0.15%) ⬇️
rafs/src/lib.rs 65.24% <100.00%> (-0.22%) ⬇️
rafs/src/metadata/direct_v6.rs 44.52% <100.00%> (ø)
rafs/src/metadata/inode.rs 95.39% <100.00%> (ø)
rafs/src/metadata/layout/v6.rs 85.18% <100.00%> (-0.01%) ⬇️
service/src/blob_cache.rs 82.69% <100.00%> (ø)
... and 17 more

... and 13 files with indirect coverage changes

@imeoer
Copy link
Collaborator

imeoer commented Dec 28, 2023

Thanks for the work, how about using the latest rust stable 1.75.0 ?

@Desiki-high
Copy link
Member Author

Thanks for the work, how about using the latest rust stable 1.75.0 ?

I just found out that the latest version is 1.74.1: https://github.com/rust-lang/rust/releases/tag/1.74.1 .

@imeoer
Copy link
Collaborator

imeoer commented Dec 28, 2023

I just found out that the latest version is 1.74.1: https://github.com/rust-lang/rust/releases/tag/1.74.1 .

Ok, strange page here.

@Desiki-high
Copy link
Member Author

I just found out that the latest version is 1.74.1: https://github.com/rust-lang/rust/releases/tag/1.74.1 .

Ok, strange page here.

It looks like a release roadmap, maybe v1.75 will be released later. Anyway, I think v1.74.1 can be accepted.

@adamqqqplay
Copy link
Member

@Desiki-high I recommend upgrading the rust version to 1.72.0 (or 1.72.1).
This version is currently used by the Kata Containers. If the nydus version is too high, it may introduce some dependency problems.

@Desiki-high
Copy link
Member Author

@Desiki-high I recommend upgrading the rust version to 1.72.0 (or 1.72.1). This version is currently used by the Kata Containers. If the nydus version is too high, it may introduce some dependency problems.

Thanks for your reminder.

@Desiki-high Desiki-high changed the title rust: bump 1.74.1 and fix errors rust: bump 1.72.1 and fix errors Dec 28, 2023
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks!

@imeoer imeoer merged commit f085879 into dragonflyoss:master Dec 29, 2023
55 checks passed
@adamqqqplay
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants