Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

did you mean 'compatible'? #2

Closed
wants to merge 1 commit into from
Closed

did you mean 'compatible'? #2

wants to merge 1 commit into from

Conversation

0xflotus
Copy link

No description provided.

@jiangliu
Copy link
Collaborator

Thanks for the MR, could you please help to add signoff and a better description?

@bergwolf
Copy link
Member

@0xflotus Thanks for spotting that! Besides @jiangliu's comments, please also fix the commit title. did you mean 'compatible' is not a proper commit title. Something like readme: fix typo is much better.

@bergwolf
Copy link
Member

Since the PR is not formatted properly and has been stale for a long time, I've raised #12 and folded the fix there. Thanks @0xflotus !

@bergwolf bergwolf closed this Oct 22, 2020
@0xflotus 0xflotus deleted the patch-1 branch October 22, 2020 07:33
@0xflotus
Copy link
Author

Oh sorry, I didn't recognized it. 😓

imeoer referenced this pull request in imeoer/image-service Dec 12, 2022
@imeoer
Merge pull request #2 from ktock/estargz
1bd9c83 
Support estargz conversion
daiyongxuan added a commit to daiyongxuan/nydus that referenced this pull request Oct 14, 2024
@daiyongxuan
# This is a combination of 2 commits.
7b5dc5b 
# This is the 1st commit message:

Feat: Add Prefetch Bootstrap Build

# This is the commit message dragonflyoss#2:

sync

tag: Add a runable example

add prefetch bootstrap

Refactor: change the test root

WIP: gen an empty blob, enter in blob.rs:33

chore: remove unused comments

WIP: generate blob id

WIP: update blob id

Refractor: remove some unuseful import and parameters

WIP: need to encapsulation the reader

ROLLBACK: Generate a blob

WIP: Revert files

WIP: revert files

WIP: Generate Blob And Compute Blob ID

feat: Generate Prefetch blobs

refractor: remove some unuse imports and functions

Add #![deny(warnings)] to enforce warning-free code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xflotus @jiangliu @bergwolf