Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#137 Add check for multiple question marks #148

Merged
merged 2 commits into from
Aug 10, 2023
Merged

#137 Add check for multiple question marks #148

merged 2 commits into from
Aug 10, 2023

Conversation

LeoVie
Copy link

@LeoVie LeoVie commented Oct 1, 2022

This solves #137

Passing two question marks into a cron expression does not really make sense in my opinion, as you would neither specify the day of month nor the day of week. Wikipedia states

In some implementations, used instead of '*' for leaving either day-of-month or day-of-week blank.

I guess, this is the implementation this library is following.

I've also added a check to validate if there are question marks in parts, where they are not allowed.
Maybe there should be an extra step to validate each part against it's allowed values. What do you think about this?

@DKhalil
Copy link

DKhalil commented Jun 5, 2023

@dragonmantank is it possible to merge this?

@dragonmantank dragonmantank merged commit 8e78e44 into dragonmantank:master Aug 10, 2023
@dragonmantank
Copy link
Owner

Merged, will release here soon. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants