#137 Add check for multiple question marks #148
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #137
Passing two question marks into a cron expression does not really make sense in my opinion, as you would neither specify the day of month nor the day of week. Wikipedia states
I guess, this is the implementation this library is following.
I've also added a check to validate if there are question marks in parts, where they are not allowed.
Maybe there should be an extra step to validate each part against it's allowed values. What do you think about this?