Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TESTBUG][CI]runtime/coroutine/c1AssertFailTest.sh健壮性不够导致用例随机失败 #605

Closed
sendaoYan opened this issue Dec 8, 2023 · 0 comments
Closed

[TESTBUG][CI]runtime/coroutine/c1AssertFailTest.sh健壮性不够导致用例随机失败 #605

sendaoYan opened this issue Dec 8, 2023 · 0 comments
Assignees
@jia-wei-tang

Comments

@sendaoYan
Copy link
Collaborator

测试job：https://github.com/dragonwell-project/dragonwell8/actions/runs/7139838371/job/19444520828?pr=604

如下图所示，启动java进程并放后台运行，用例预期每次该java进程运行超过2s再退出。而实际情况是，并不能保证该java进程在任意测试环境上，每次都能启动超过2s

image

修改建议：

1、在shell脚本加上set -x命令，增加调试信息，方便用例失败时根据调试信息确认用例失败原因
2、java命令之前加上time前缀，用例失败时可以得到java命令具体的执行时间
3、根据用例的测试意图，修改为更为健壮的方式，而不是通过sleep 2的方式

测试job截图：

image
@sendaoYan sendaoYan assigned yuleil and jia-wei-tang and unassigned yuleil Dec 8, 2023
jia-wei-tang added a commit to jia-wei-tang/dragonwell8 that referenced this issue Dec 11, 2023
@jia-wei-tang
[Wisp] only test c1 assertion failure in slowdebug mode
6a5c643 
Summary: Determine the java mode before run normal logics.
If java is release or fastdebug, just go to the ending early.

Testing: hotspot/test/runtime/coroutine/c1AssertFailTest.sh

Reviwers: lingjun-cg, yulei

Issue: dragonwell-project#605
@jia-wei-tang jia-wei-tang mentioned this issue Dec 11, 2023
Merged
jia-wei-tang added a commit to jia-wei-tang/dragonwell8 that referenced this issue Dec 11, 2023
@jia-wei-tang
[Wisp] only test c1 assertion failure in slowdebug mode
a9052cf 
Summary: Determine the java mode before run normal logics.
If java is release or fastdebug, just go to the ending early.

Testing: hotspot/test/runtime/coroutine/c1AssertFailTest.sh

Reviewrs: lingjun-cg, yulei

Issue: dragonwell-project#605
jia-wei-tang added a commit to jia-wei-tang/dragonwell8 that referenced this issue Dec 11, 2023
@jia-wei-tang
[Wisp] only test c1 assertion failure in slowdebug mode
7a5d025 
Summary: Determine the java mode before run normal logics.
If java is release or fastdebug, just go to the ending early.

Testing: hotspot/test/runtime/coroutine/c1AssertFailTest.sh

Reviewers: lingjun-cg, yulei

Issue: dragonwell-project#605
jia-wei-tang added a commit that referenced this issue Dec 11, 2023
@jia-wei-tang
[Wisp] only test c1 assertion failure in slowdebug mode
ec6f074 
Summary: Determine the java mode before run normal logics.
If java is release or fastdebug, just go to the ending early.

Testing: hotspot/test/runtime/coroutine/c1AssertFailTest.sh

Reviewers: lingjun-cg, yulei

Issue: #605
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jia-wei-tang jia-wei-tang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yuleil @sendaoYan @jia-wei-tang