Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc] Update dragonwell version to 8.0.0 #31

Merged
merged 1 commit into from
May 27, 2019
Merged

[Misc] Update dragonwell version to 8.0.0 #31

merged 1 commit into from
May 27, 2019

Conversation

yfxhust
Copy link
Contributor

@yfxhust yfxhust commented May 23, 2019

Summary:
Update dragonwell version to 8.0.0

Test Plan: make.sh saint check.

Reviewed-by: D-D-H, mmyxym, luchsh

Issue: #30

@yfxhust yfxhust requested review from luchsh, D-D-H and mmyxym May 23, 2019 06:04
D-D-H
D-D-H approved these changes May 23, 2019
View reviewed changes
Copy link
Collaborator

@D-D-H D-D-H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

luchsh
luchsh reviewed May 23, 2019
View reviewed changes
make.sh Show resolved Hide resolved
@luchsh
Copy link
Contributor

luchsh commented May 23, 2019

Could you please show us what the new output of Dragonwell8/bin/java -version looks like now?

@yfxhust
[Misc] Update dragonwell version to 8.0.0
1e1beee 
Summary:
Update dragonwell version to 8.0.0

Test Plan: make.sh saint check.

Reviewed-by: D-D-H, mmyxym, luchsh

Issue: dragonwell-project#30
@yfxhust
Copy link
Contributor Author

yfxhust commented May 24, 2019 

Finished building OpenJDK for target 'images'
openjdk version "1.8.0_202"
OpenJDK Runtime Environment (Alibaba Dragonwell 8.0.0-bb66) (build 1.8.0_202-b01)
OpenJDK 64-Bit Server VM (Alibaba Dragonwell 8.0.0-bb66) (build 25.202-b01, mixed mode)
java.vm.vendor="Alibaba"
java.vendor.url=http://www.alibabagroup.com
java.vendor=Alibaba
java.vendor.url.bug=mailto:dragonwell_use@googlegroups.com
OpenJDK Runtime Environment (Alibaba Dragonwell 8.0.0-bb66) (build 1.8.0_202-b01)
OpenJDK 64-Bit Server VM (Alibaba Dragonwell 8.0.0-bb66) (build 25.202-b01, mixed mode)
        libz.so.1 => /lib64/libz.so.1 (0x00007ffbb6b15000)

This is the output for the jdk applied my patch.
bb66 is my magic build number. I think it is as same as what I expect.

@yfxhust
Copy link
Contributor Author

yfxhust commented May 24, 2019

I think --with-build-number can work.

@yfxhust yfxhust requested a review from luchsh May 24, 2019 09:21
@yfxhust yfxhust merged commit bc893c9 into dragonwell-project:master May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmyxym mmyxym mmyxym approved these changes

@D-D-H D-D-H D-D-H approved these changes

@luchsh luchsh luchsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yfxhust @luchsh @D-D-H @mmyxym