[Backport] Backport JFR Streaming API to Dragonwell 8 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuaiwei
reviewed
Jul 26, 2020
| @@ -303,6 +310,10 @@ JVM_ENTRY_NO_ENV(jboolean, jfr_event_writer_flush(JNIEnv* env, jclass cls, jobje | |||
| return JfrJavaEventWriter::flush(writer, used_size, requested_size, thread); | |||
| JVM_END | |||
|
|
|||
| JVM_ENTRY_NO_ENV(void, jfr_flush(JNIEnv* env, jobject jvm)) | |||
There was a problem hiding this comment.
I'm wondering why jfr entry always has a jvm argument and not use it.
There was a problem hiding this comment.
it isn't a static method and the argument 'jvm' is the receiver
kuaiwei
reviewed
Jul 30, 2020
kuaiwei
approved these changes
Jul 31, 2020
yuleil
approved these changes
Jul 31, 2020
Summary: Test Plan: jdk/jfr Reviewed-by: yuleil Issue: dragonwell-project/dragonwell8#112
…f checkpoint data Summary: Test Plan: jdk/jfr Reviewed-by: yuleil Issue: dragonwell-project/dragonwell8#112
Summary: Test Plan: jdk/jfr Reviewed-by: yuleil Issue: dragonwell-project/dragonwell8#112
…trace Summary: Test Plan: jdk/jfr Reviewed-by: yuleil Issue: dragonwell-project/dragonwell8#112
Summary: Test Plan: jdk/jfr Reviewed-by: yuleil Issue: dragonwell-project/dragonwell8#112
Summary: Test Plan: jdk/jfr Reviewed-by: yuleil Issue: dragonwell-project/dragonwell8#112
…ssertion failure Summary: Test Plan: jdk/jfr Reviewed-by: yuleil Issue: dragonwell-project/dragonwell8#112
…reads Summary: Test Plan: jdk/jfr Reviewed-by: yuleil Issue: dragonwell-project/dragonwell8#112
…hread JFR Event Stream" Summary: Test Plan: jdk/jfr Reviewed-by: yuleil Issue: dragonwell-project/dragonwell8#112
Summary: Test Plan: jdk/jfr Reviewed-by: yuleil Issue: dragonwell-project/dragonwell8#112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: dragonwell-project/dragonwell8#112