[Misc] Resource Management API #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
luchsh
reviewed
Mar 11, 2020
| return ROOT; | ||
| } | ||
|
|
||
| public static AbstractResourceContainer current() { |
There was a problem hiding this comment.
current() == null looks like undefined behavior, we'd better return non-null value, either ROOT or current
if (!VM.isBooted()) {
return root();
}
return JLA.getResourceContainer(Thread.currentThread());
There was a problem hiding this comment.
👍
It's a good idea to ensure that Thread.resourceContainer is always not null. 😋
| * with {@link ResourceContainer#current()} | ||
| */ | ||
| protected void detach() { | ||
| JLA.setResourceContainer(Thread.currentThread(), null); |
There was a problem hiding this comment.
JLA.setResourceContainer(Thread.currentThread(), root())
Summary: Introduce ResourceContainer to manage resources. ResourceContainer defines a set of resource Constraint that limit resource usage by threads. Test Plan: jtreg com/alibaba/rcm Reviewed-by: luchsh, sanhong Issue: dragonwell-project/dragonwell8#87
kuaiwei
approved these changes
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Introduce ResourceContainer to manage resources.
ResourceContainer defines a set of resource Constraint
that limit resource usage by threads.
Test Plan: jtreg com/alibaba/rcm
Reviewed-by: luchsh sanhong
Issue: dragonwell-project/dragonwell8#87