Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore view context patching to Action Mailer #241

Merged
merged 2 commits into from
Jul 19, 2012
Merged

Restore view context patching to Action Mailer #241

merged 2 commits into from
Jul 19, 2012

Conversation

rf-
Copy link
Contributor

@rf- rf- commented Jul 19, 2012

The main change here is moving the view context patching back into Draper::System.setup, which makes Draper work properly in Action Mailer again.

I also removed a couple of view_context calls that aren't necessary anymore. There may be others, but by inspection it looks like all of the remaining calls are actually necessary.

@travisbot
Copy link

This pull request passes (merged 75a8204 into c54341c).

@rf-
Copy link
Contributor Author

rf- commented Jul 19, 2012

A side note: why does Draper now depend on Rails 3.2? Is there really anything in there that won't work with 3.1?

@steveklabnik
Copy link
Member

why does Draper now depend on Rails 3.2?

Rails 3.2 is the only supported version by the Rails team. And therefore, the only version I officially support with Draper. I don't remember if it's a hard dependency or not, to be honest. 3.1.x is security fixes only.

steveklabnik added a commit that referenced this pull request Jul 19, 2012
Restore view context patching to Action Mailer
@steveklabnik steveklabnik merged commit 7248ea2 into drapergem:master Jul 19, 2012
@steveklabnik
Copy link
Member

Thanks for doing this work, by the way. :)

@rf-
Copy link
Contributor Author

rf- commented Jul 19, 2012

Thanks for doing this work, by the way. :)

No problem.

Rails 3.2 is the only supported version by the Rails team. And therefore, the only version I officially support with Draper.

This is a weird conflation of two different meanings of the word "support". You can allow people to install Draper on Rails 3.1 without signing a binding contract that you'll personally fix any problem anyone ever has with it.

I don't remember if it's a hard dependency or not, to be honest.

It is a hard dependency.

@steveklabnik
Copy link
Member

I didn't mean hard as in the gemfile, I meant hard as in "I don't remember if I'm relying on any 3.2 behavior."

Maybe it's just me, but if I saw ~> 3.1 in a Gemfile, i'd assume that 3.1 is supported by the author. If someone wants to run Draper with Rails 3.1, they can really easily do this in combination with `gem "draper", :github => "foo/draper" and run it on whatever they'd like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants