Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix-std-github-url] Fixed the url for std github urls in module service #22

Merged
merged 1 commit into from
Jun 19, 2020
Merged

[fix-std-github-url] Fixed the url for std github urls in module service #22

merged 1 commit into from
Jun 19, 2020

Conversation

ebebbington
Copy link
Member

The old url is invalid for traversing through a repositories directories

Guergeiro
Guergeiro approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@Guergeiro Guergeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will assume you have tested this exhaustively to even find out about this error...

@ebebbington ebebbington merged commit 37f179d into master Jun 19, 2020
@ebebbington ebebbington deleted the fix-std-github-url branch June 19, 2020 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guergeiro Guergeiro Guergeiro approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ebebbington @Guergeiro