Issue #13 add support version

[melhirech]

Fixes #13

• Add dmm --version functionality (can be tested by doing deno run mod.ts --version)

• Update helpMessage inside src/options/help.ts to include this new functionality

• Update README to include this

• Update DEV.md to have that version string updated on a new release

• Add tests at tests/options/version_test.ts to assert it works correctly

• Use regex to check version value string in version_test.ts

[Guergeiro]

Everything looks good!

Do you think you can do what I suggested? If so, I think you can do it in pretty much all our repositories. Just need to open an issue 😃

[Guergeiro]

I'm skeptical about hardcoded version assertions... That's something we even removed from Drash because it's mehhhh...

I might have a suggestion for this (haven't talked to @ebebbington or @crookse about it). Instead of asserting a specific version, we assert:

1. Output is not empty.
2. Output follows a regex that matches a valid semver string. Link to official regex here.

Honestly, if we assert number 2, we don't have to assert 1 since that case is covered in 2.

[ebebbington]

@Guergeiro that's a good idea actually

I think the following regex would suffice: /dmm(v)?[0-9].+[0-9].+[0-9]/g; (which is actually used in dmm to get imported versions)

[Guergeiro]

I don't see a problem in using the official regex though. They cover alpha releases, release candidates, etc. We literally only have to copy 😆

[melhirech]

@Guergeiro The regex approach sound seems good to me, I'll add the official regex since it covers all possible cases.

[crookse]

Let’s make sure we add a comment stating where we got the regex. I like to know where we get code from when it’s copied.

[melhirech]

https://regexr.com/39s32

/^((([0-9]+)\.([0-9]+)\.([0-9]+)(?:-([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?)(?:\+([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?)$/

What do you guys think about this? I guess this should do the work.

EDIT:
I edited the regex to include dmm.
const regex = /^((?:dmm)?\s)((([0-9]+)\.([0-9]+)\.([0-9]+)(?:-([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?)(?:\+([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?)$/

[Guergeiro]

I would prefer if it was done separately. Pseudocode:

const reg = /^((([0-9]+)\.([0-9]+)\.([0-9]+)(?:-([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?)(?:\+([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?)$/;
const variable = "dmm 1.5.5";
const splittedString = variable.split(" ");
assertTrue(splittedString.length == 2);
assertEquals(splittedString[0], "dmm");
assertTrue(reg.test(splittedString[1]);

[Guergeiro]

Good job! 🚀