Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import #47

Merged
merged 6 commits into from
Aug 7, 2020
Merged

Fix import #47

merged 6 commits into from
Aug 7, 2020

Conversation

ebebbington
Copy link
Member

@ebebbington ebebbington commented Aug 3, 2020

Description

  • Update readme

  • Remove v in std imports or version strings as this is no longer supported

  • Fix logic to get info on modules due to how the registry has changed

  • Fix tests following all this

  • Dont use hard coded values for latest std and drash release, and instead use existing logic, meaning this is one thing less to update on releases

Copy link
Member

@crookse crookse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments

src/services/deno_service.ts Show resolved Hide resolved
src/services/deno_service.ts Outdated Show resolved Hide resolved
@ebebbington ebebbington linked an issue Aug 5, 2020 that may be closed by this pull request
1 task
@crookse crookse self-requested a review August 7, 2020 19:45
@ebebbington ebebbington merged commit 0a31c3f into master Aug 7, 2020
@ebebbington ebebbington deleted the fix-import branch August 7, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Remove Instances of v in Std Versions
2 participants