chore: Doc, output and code improvements #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebebbington
added
the
Type: Chore
crookse
previously approved these changes
Oct 21, 2020
|
Yeah I’m happy with that, I’m just in the process of fixing the tests and using the logging service instead of console.logs |
ebebbington
changed the title
|
@crookse Just need you to review my recent changes then i think we should be good! |
|
Actually hold on Eric, i'm going to abstract the logic for the deno versions strings into the services repo, this will help immensely as i believe all repos have pretty much the same logic for handling it |
|
Warning: #77 will create merge conflicts with this PR (i believe the nest pr will be merged first), but in essence we just need to keep the documentation that Nest is now a supported registry - i think only the tests and readme will have conflicts, as in this PR the readme was super simplified |
# Conflicts: # README.md # tests/integration/check_test.ts # tests/integration/update_test.ts
crookse
added
the
Type: Minor
crookse
previously approved these changes
Oct 30, 2020
Merged
Update dependencies
crookse
approved these changes
Oct 31, 2020
ebebbington
commented
Oct 31, 2020
ebebbington
commented
Oct 31, 2020
crookse
removed
the
Type: Chore
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ERRORfrom the services repohelpandversioncommandsinfocommand so that you can pass in multiple modules (e.g.,dmm info fs drash http).README.md, remove unnecessary documentation