chore: Refactor #89
Merged
chore: Refactor #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebebbington
added
the
Type: Chore
ebebbington
commented
Nov 9, 2020
crookse
reviewed
Nov 10, 2020
crookse
reviewed
Nov 10, 2020
|
Lol, did you want to support if people do vx.x.x.x? (4th set) Im not trying to shut you down |
|
i would want the regex to support any version possible lol. before i was like "we should only support v1.2.3 or 1.2.3 because that's the standard" but really it's not the standard. we don't know what the standard should be so we should be inclusive to modules that use wack ass versioning |
|
we can address this in another issue, whilst my opinion is "use v.x.x.x", we probably should add support for it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #88
Summary