Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support waiting for requests #126

Merged
merged 4 commits into from
May 30, 2022
Merged

feat: Support waiting for requests #126

merged 4 commits into from
May 30, 2022

Conversation

ebebbington
Copy link
Member

closes #26

not proud of it tbh, but i think until we refactor the deferred stuff, this might be the best way?

A big step for sinco though, meaning JS functionality can be tested, submitting forms, uploading images etc

@ebebbington ebebbington added the Type: Minor Merging this pull request results in a minor version increment label Apr 28, 2022
@ebebbington ebebbington mentioned this pull request Apr 28, 2022
4 tasks
Copy link
Member

@crookse crookse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree that this could be cleaned up. i think the refactor to the deferred stuff would help a ton. however, the code is easy to read imo (i know that's subjective, but that's my opinion)

@ebebbington ebebbington merged commit 67ac788 into main May 30, 2022
@ebebbington ebebbington deleted the wait-for-reqs branch May 30, 2022 19:49
SnoCold added a commit to SnoCold/sinco that referenced this pull request Jun 4, 2022
more stabilizations

another commit

commit

feat: Support waiting for requests (drashland#126)

* feat: Support waiting for requests

* docblocks

* rm logging

* fmt

feat: Support setting files on inputs (drashland#118)

* feat: Support setting files on inputs

* add tests

* fix tests

* fix again

feat: Support arugments for evaluate() function callbacks (drashland#122)

* feat: Support arugments for evaluate() function callbacks

* lint

feat: Support dialogs (drashland#124)

* feat: Support dialogs

* rm logging

* fix(page): add period to end of error message

* Update server.ts

* Update server.ts

* Update page_test.ts

Co-Authored-By: Eric Crooks <eric.crooks@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Minor Merging this pull request results in a minor version increment
Development

Successfully merging this pull request may close these issues.

Wait for Http Requests
2 participants