-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING: Refactor whole codebase #145
Open
ebebbington
wants to merge
35
commits into
main
Choose a base branch
from
change-console-error-method
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebebbington
changed the title
Replace assertNoConsoleErrors with consoleErrors
BREAKING: Refactor whole codebase
May 2, 2024
Closed
Big change log i need to eventually work up.. but in a nutshell: (note: idea is to just be simple man... a lightweight way to just run a subprocess to get some browser tests done)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General
buildFor
Client.create()
browser
parameter from the options, it only uses chrome nowBrowser/Client
.page()
This is part of the bigger picture to remove this page management we felt wasn't needed
.closeAllPagesExcept()
This is part of the bigger picture to remove this page management we felt wasn't needed
Elements
.file()
/.files()
page.setInputFiles({ selector: 'string', files: array<string> })
instead.value()
.evaluate()
instead.takeScreenshot()
page.screenshot({ element: 'string' })
instead.click()
page.evaluate('document.querySelector("button").click()');
insteadwaitUntilNetworkIdle()
if clicking triggers any form of network requestpage.newPageClick()
when clicking something that will open a new tabPage
.querySelector()
.close()
browser.close()
.expectWaitForRequest()
waitUntilNetworkIdle()
.location()
.evaluate(window.location.href)
instead.assertNoConsoleErrors()
-->.consoleErrors()
.
takeScreenshot()
.screenshot()
Idea was to give the responsibility of handling/saving the file to the user, so you can save it if you wish
.expectDialog
.evaluate()
) then do not awaitevaluate