Handle timeout due to pool exhaustion #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbfaulkner
changed the title
rud
approved these changes
Apr 18, 2023
sbfaulkner
force-pushed
the
handle-timeout-due-to-starvation
branch
from
25c2dd9 to
c3eb6e4
Compare
|
rebased and re-bumped version |
|
I still find this a good set of changes |
|
Yes this is good. Sorry I didn't see it for the past 3 years 😓 If you rebase one more time I'll merge. |
sbfaulkner
force-pushed
the
handle-timeout-due-to-starvation
branch
from
c3eb6e4 to
49d678c
Compare
sbfaulkner
force-pushed
the
handle-timeout-due-to-starvation
branch
from
b53e9a7 to
6665d26
Compare
|
@tenderlove so be it... rebased and ready for your tender loving care 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the pool has no more available connections, it raises a timeout exception (ConnectionPool::TimeoutError which is a subclass of Timeout::Error)
however the
ensurecurrently catches it and masks that exception with aConnectionPool::Error: no connections are checked outas far as I can tell, scoping the exception handling block a little tighter has no other impact than letting this exception through, so the consumer can actually detect the issue
any feedback/suggestions/alternatives welcome
cc @drbrain @tenderlove