Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4/4 Support GeoTIFF data in TIFF #586

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

don-vip
Copy link

@don-vip don-vip commented Jun 19, 2022

This is the fourth and final step towards solving #278

It includes:

  1. ports of commits from Add GeoTIFF support metadata-extractor-dotnet#307
  2. some bug fixes (I'll open a PR in metadata-extractor-dotnet)
  3. a new unit test to check GeoTIFF parsing, using data set taken from OSGEO/libgeotiff
  4. addition of new EPSG codes used in the libgeotiff samples

It is based on #585. Feel free to close the three others if you prefer to merge all my work in this PR :)

don-vip and others added 13 commits July 20, 2024 16:37
… than passing TIFF header offsets around everywhere.
Note that while BigTIFF supports files greater than 2 GiB in size, our current implementation does not due to the pervasive use of Int32 throughout the code to represent offsets into the data.
This will only ever be a 16-bit value.
This allows combining the add and test operations into a single lookup.
If the byte order changes during extraction, a new reader is made via WithByteOrder.
That new reader is naturally scoped to the sub-reading operation, and the byte order
does not need to be reverted.
We have been steadily adding parameters to members of ITiffHandler. We are about to add more to support GeoTIFF. Rather than do that, introduce a new type that encapsulates this common state. This makes the API simpler, and means we can add members in future without it being a breaking change.
@don-vip
Copy link
Author

don-vip commented Jul 29, 2024

OK everything is rebased now. I have created drewnoakes/metadata-extractor-images#53 for test data. If you accept these changes, feel free to drop the last commit of this PR which added test data to this repository, before I knew about the other one.

@don-vip
Copy link
Author

don-vip commented Aug 31, 2024

Hi @drewnoakes is it possible to merge this? I believe to have done everything that was required.

@dpriskorn
Copy link

dpriskorn commented Oct 18, 2024

@don-vip Does this support https://www.wikidata.org/wiki/Q112509098 COG also?

@stoecker
Copy link

"A Cloud Optimized GeoTIFF (COG) is a regular GeoTIFF file, aimed at being hosted on a HTTP file server, with an internal organization that enables more efficient workflows on the cloud.", so it should.

@don-vip
Copy link
Author

don-vip commented Oct 18, 2024

@dpriskorn as Dirk said, yes it should. I had to create a release for my own project in my fork, you can give it a try to check until this PR is merged in the main repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants