Skip to content

Commit

Permalink
Fix a typo in the data_feedback_insert_element attribute and use a …
Browse files Browse the repository at this point in the history
…div instead of a span.

This is not particularly consequential since the feedback button is
still inserted after the select.  That is the same as what the data
attributes end up doing.

However, using a `span` is a problem, becuase the feedback popover is
inserted into the span which results in invalid HTML.
  • Loading branch information
drgrice1 committed Dec 8, 2024
1 parent 1e3d69b commit 888bcfe
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions macros/parsers/parserPopUp.pl
Original file line number Diff line number Diff line change
Expand Up @@ -389,10 +389,10 @@ sub MENU {

if ($main::displayMode =~ m/^HTML/) {
$menu = main::tag(
'span',
class => 'text-nowrap',
data_feedback_insert_elt => $name,
data_feedback_insert_method => 'append_content',
'div',
class => 'd-inline text-nowrap',
data_feedback_insert_element => $name,
data_feedback_insert_method => 'append_content',
main::tag(
'select',
class => 'pg-select',
Expand Down

0 comments on commit 888bcfe

Please sign in to comment.