Skip to content

Commit

Permalink
Add wording for "down" versus "stop" to the comment in docker-compose…
Browse files Browse the repository at this point in the history
….dist.yml.
  • Loading branch information
drgrice1 committed Nov 11, 2024
1 parent 868aafa commit 0339cc6
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion conf/authen_saml2.conf.dist
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!perl
################################################################################
# Configuration for using Saml2 authentication.
# To enable this Saml2 authentication, copy this file to conf/authen_saml2.conf
# To enable Saml2 authentication, copy this file to conf/authen_saml2.conf
# and uncomment the appropriate lines in localOverrides.conf. The Saml2
# authentication module uses the Net::SAML2 library. The library claims to be
# compatible with a wide range of SAML2 implementations, including Shibboleth.
Expand Down
5 changes: 3 additions & 2 deletions docker-config/docker-compose.dist.yml
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,9 @@ services:
# - "6311:6311"

# SimpleSAMLphp Saml2 identity provider for development use only. This is a separate profile from the other services
# so it doesn't start in normal usage. Use "docker compose --profile saml2dev up" to start, and "docker compose
# --profile saml2dev down" to stop.
# so it doesn't start in normal usage. Use "docker compose --profile saml2dev up" to start, "docker compose --profile
# saml2dev stop" to stop services, and "docker compose --profile saml2dev down" to stop services and remove
# containers.
idp:
build:
context: ./docker-config/idp/
Expand Down
4 changes: 2 additions & 2 deletions lib/WeBWorK/Authen/Saml2.pm
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ sub do_verify ($self) {
$c->param('key', $self->{session_key});
$c->stash->{saml2_redirect} = $c->systemLink($c->url_for($c->stash->{saml2}{relayState}{url}));

# Save these in the stash for now. They will be transfered to the session after it has been created.
# Save these in the stash for now. They will be transferred to the session after it has been created.
$c->stash->{saml2_nameid} = $assertion->nameid;
$c->stash->{saml2_session} = $assertion->{session};

Expand Down Expand Up @@ -205,7 +205,7 @@ sub sp ($self) {
}

# The first time this method is executed for a given identity provider, the metadata file is retrieved from the metadata
# URL. It is then saved in the the $ce->{saml2}{active_idp} subdirectory of $ce->{webworkDirs}{DATA}/Saml2IDPs together
# URL. It is then saved in the $ce->{saml2}{active_idp} subdirectory of $ce->{webworkDirs}{DATA}/Saml2IDPs together
# with the identity provider's signing key which is extracted from the retrieved metadata. On later requests the
# metadata and certificate are used from the saved files. This prevents the need to retrieve the metadata on every
# login request.
Expand Down

0 comments on commit 0339cc6

Please sign in to comment.