Skip to content

Commit

Permalink
Updates from review.
Browse files Browse the repository at this point in the history
Don't show the quiz timer for instructors who can submit student
answers after the due date.

Update the help language to try to better describe how dangerous it
is to leave the record_answers_when_acting_as_student permission on.
  • Loading branch information
somiaj committed Dec 10, 2024
1 parent 46f78c6 commit 8a50103
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions lib/WeBWorK/ConfigValues.pm
Original file line number Diff line number Diff line change
Expand Up @@ -532,10 +532,10 @@ sub getConfigValues ($ce) {
'When acting as a student, this permission level and higher can submit answers for that student, '
. 'which includes starting and grading test versions. This permission should only be turned '
. 'on temporarily and set back to "nobody" after you are done submitting answers for a '
. 'student, as it can interfere with tests. If you have this permission and are viewing a '
. 'test version for a student that is also working on that version, your answers will be '
. 'saved for that student when moving between pages, which could reset or change the answers '
. 'entered in by the student.'
. 'student. Leaving this permission on is dangerous, as you could unintentionally submit '
. 'answers for a student, which can use up their total number of attempts. Further, if you '
. 'are viewing an open test version, your answers on each page will be saved when you move '
. q/between pages, which will overwrite the student's saved answers./
),
type => 'permission'
},
Expand Down
4 changes: 2 additions & 2 deletions templates/ContentGenerator/GatewayQuiz.html.ep
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@
% # Remaining output of test headers.
% # Display timer or information about elapsed time, output link, and information about any recorded score if not
% # submitAnswers or checkAnswers.
% if ($c->{can}{recordAnswersNextTime} || $c->{can}{gradeUnsubmittedTest}) {
% if ($c->{can}{recordAnswersNextTime} && before($c->{set}->due_date + $ce->{gatewayGracePeriod}, $submitTime)) {
% my $timeLeft = $c->{set}->due_date - int($submitTime); # This is in seconds
%
% # Print the timer if there is less than 24 hours left.
Expand Down Expand Up @@ -657,7 +657,7 @@
% && (!$c->{can}{recordAnswersNextTime} || $c->{can}{showProblemGrader})) {
<%= submit_button maketext('Check Test'), name => 'checkAnswers', class => 'btn btn-primary mb-1' =%>
% }
% if ($c->{can}{recordAnswersNextTime} || $c->{can}{gradeUnsubmittedTest}) {
% if ($c->{can}{recordAnswersNextTime}) {
<%= tag('input',
type => 'submit',
name => 'submitAnswers',
Expand Down

0 comments on commit 8a50103

Please sign in to comment.