Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test #38

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

test #38

wants to merge 5 commits into from

Conversation

driazati
Copy link
Owner

@driazati driazati commented Nov 2, 2022

2

@driazati driazati force-pushed the test1 branch 7 times, most recently from ddbca5b to a2e4a8b Compare November 4, 2022 03:24
curl -L -o /usr/local/bin/sccache https://tvm-ci-resources.s3.us-west-2.amazonaws.com/sccache/macos/sccache
chmod +x /usr/local/bin/sccache
sccache --help
exit 1
Copy link

@ehsanmok ehsanmok Nov 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why exit here?
Update: I see you're testing on MacOS

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular sccache config?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code change here is mixed up with some others, the sccache + mamba parts aren't entirely done and would be split out before merging into TVM. This PR is mostly just to demo the checks box below with the Jenkins links

driazati added a commit that referenced this pull request Nov 4, 2022
This breaks up the Jenkinsfile into ones for GPU, CPU, etc. This removes
a false dependency between the build and test steps (e.g. before the GPU
tests had to wait on the Hexagon build to complete) and makes the
Jenkins UI a bit better since there's not 30 tests to scroll through to
find a failure. An example can be found in my fork here:
#38 in the checks box. Before this
is merged
https://github.com/tlc-pack/ci/blob/main/jenkins/jenkins-jobs/prod/tvm.yaml
will need to be updated to accept webhooks from apache/tvm instead of my
fork.
driazati added a commit that referenced this pull request Nov 4, 2022
This breaks up the Jenkinsfile into ones for GPU, CPU, etc. This removes
a false dependency between the build and test steps (e.g. before the GPU
tests had to wait on the Hexagon build to complete) and makes the
Jenkins UI a bit better since there's not 30 tests to scroll through to
find a failure. An example can be found in my fork here:
#38 in the checks box. Before this
is merged
https://github.com/tlc-pack/ci/blob/main/jenkins/jenkins-jobs/prod/tvm.yaml
will need to be updated to accept webhooks from apache/tvm instead of my
fork.
@mehrdadh
Copy link

mehrdadh commented Nov 7, 2022

I very much like this!
Can you clarify what's the difference between tvm-hexagon/branch vs tvm-hexagon/pr_head?
My guess is that this exists only here because you're using a TVM branch instead of your fork?

@driazati
Copy link
Owner Author

driazati commented Nov 7, 2022

I very much like this! Can you clarify what's the difference between tvm-hexagon/branch vs tvm-hexagon/pr_head? My guess is that this exists only here because you're using a TVM branch instead of your fork?

The branch vs pr-head is happening since jenkins is seeing this PR from two sources, one for the branch in the driazati/tvm repo and one for the PR #38. For PRs from forks there is only the pr-head job, but there's not an easy way to get jenkins to skip scheduling the pr-head job altogether when an in-repo branch is used to make a PR. (this is the same as the current setup BTW, hopefully something we can eventually address since it is a bit confusing)

@driazati driazati force-pushed the test1 branch 3 times, most recently from 40627e8 to 9f5ec45 Compare December 6, 2022 06:37
driazati added a commit to apache/tvm that referenced this pull request Dec 6, 2022
This breaks up the Jenkinsfile into ones for GPU, CPU, etc. This removes a false dependency between the build and test steps (e.g. before the GPU tests had to wait on the Hexagon build to complete) and makes the Jenkins UI a bit better since there's not 30 tests to scroll through to find a failure. An example can be found in my fork here: driazati#38 in the checks box. Before this is merged https://github.com/tlc-pack/ci/blob/main/jenkins/jenkins-jobs/prod/tvm.yaml will need to be updated to accept webhooks from apache/tvm instead of my fork.

See #13337 for more context
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
This breaks up the Jenkinsfile into ones for GPU, CPU, etc. This removes a false dependency between the build and test steps (e.g. before the GPU tests had to wait on the Hexagon build to complete) and makes the Jenkins UI a bit better since there's not 30 tests to scroll through to find a failure. An example can be found in my fork here: driazati#38 in the checks box. Before this is merged https://github.com/tlc-pack/ci/blob/main/jenkins/jenkins-jobs/prod/tvm.yaml will need to be updated to accept webhooks from apache/tvm instead of my fork.

See apache#13337 for more context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants