Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holding back setuptools #207

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Holding back setuptools #207

merged 1 commit into from
Aug 16, 2022

Conversation

AllenDowney
Copy link
Contributor

Closes #206

@netlify
Copy link

netlify bot commented Aug 16, 2022

Deploy Preview for silly-keller-664934 ready!

Name Link
🔨 Latest commit 68924bd
🔍 Latest deploy log https://app.netlify.com/sites/silly-keller-664934/deploys/62fbe2762cdeff0008dd5d62
😎 Deploy Preview https://deploy-preview-207--silly-keller-664934.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Contributor

@AllenDowney
Copy link
Contributor Author

For reasons I don't fully understand, the version of setuptools in the conda environment doesn't seem to matter, but the version specified in pyproject.toml does.

@AllenDowney AllenDowney requested a review from ejm714 August 16, 2022 18:35
@codecov-commenter
Copy link

Codecov Report

Merging #207 (68924bd) into master (49e0e15) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #207   +/-   ##
======================================
  Coverage    86.9%   86.9%           
======================================
  Files          29      29           
  Lines        1902    1902           
======================================
  Hits         1653    1653           
  Misses        249     249           

Makefile Show resolved Hide resolved
@AllenDowney AllenDowney requested a review from ejm714 August 16, 2022 19:59
Copy link
Collaborator

@ejm714 ejm714 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AllenDowney! Can you file an issue to revisit unpinning setuptools if mkdocstrings/mkdocstrings#463 gets resolved?

@AllenDowney
Copy link
Contributor Author

Created #208

@AllenDowney AllenDowney deleted the 206-hold-back-setuptools branch August 16, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New version of setuptools breaks mkdocstrings
3 participants