Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thrust algorithms #2

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JayjeetAtGithub
Copy link
Contributor

@JayjeetAtGithub JayjeetAtGithub commented Aug 18, 2024

I started this PR to add examples for a bunch of useful thrust algorithms. I will keep adding more. Thats why I am keeping this in draft for now. But please feel free to review.

@drkennetz
Copy link
Owner

I started this PR to add examples for a bunch of useful thrust algorithms. I will keep adding more. Thats why I am keeping this in draft for now. But please feel free to review.

Sorry - I deleted my old comment. Let me review and provide some feedback. I like what you are doing here, I just might want to structure it a bit. I'll send you some thoughts later today.

@JayjeetAtGithub
Copy link
Contributor Author

Sure @drkennetz . I also wanted to unify the Makefiles a bit, into a global CMakeList.txt. If you think that's useful, I can work on it

@drkennetz
Copy link
Owner

@JayjeetAtGithub I would love that, it's been something I have been meaning to do after I realized I was going to keep building onto this repository, I just haven't gotten around to it. That would be super helpful. I'll make an issue and assign it to you?

@drkennetz
Copy link
Owner

drkennetz commented Aug 18, 2024

@JayjeetAtGithub #3

Feel free to open a separate PR.

@JayjeetAtGithub JayjeetAtGithub marked this pull request as ready for review August 18, 2024 19:24
@drkennetz
Copy link
Owner

@JayjeetAtGithub I made some pretty big improvements to the repo based on what we discussed. I also updated CMake a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants