Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy::pedantic #149

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Fix clippy::pedantic #149

merged 2 commits into from
Aug 1, 2024

Conversation

GnomedDev
Copy link
Contributor

Pedantic is a group of lints that are default allowed, but include some lints for pedantic people. This also includes a couple performance improvements, but mostly not. This PR enables them, and selectively allows a couple that I personally dislike handling.

@GnomedDev GnomedDev force-pushed the fix-clippy-pedantic branch from eb90c57 to cd8d3b8 Compare August 1, 2024 16:43
@GnomedDev
Copy link
Contributor Author

The CI improvements I just made also seem to reduce CI runtime from 2 minutes to ~50 seconds, as everything is done in parallel.

Copy link
Member

@lulf lulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for cleaning and improving 🎉🚀

@lulf
Copy link
Member

lulf commented Aug 1, 2024

The CI improvements I just made also seem to reduce CI runtime from 2 minutes to ~50 seconds, as everything is done in parallel.

Good! The reason it was only a single job was that the other drogue projects shared the CI resources. They are however less active so improving parallelism for embedded-tls is good!

@lulf lulf merged commit 0e2b640 into drogue-iot:main Aug 1, 2024
7 checks passed
@GnomedDev GnomedDev deleted the fix-clippy-pedantic branch August 2, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants