Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added times string conversion support #176

Closed
wants to merge 3 commits into from
Closed

Added times string conversion support #176

wants to merge 3 commits into from

Conversation

MohammadGhodsian
Copy link

Structs, creators and json methods are added for support string conversion by these layouts: TimeLayout, TimeMilliLayout, TimeMicroLayout and TimeNanoLayout. Creator of new carbon pointer also added.

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -2.12 ⚠️

Comparison is base (95c04a7) 99.89% compared to head (4f69859) 97.77%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
- Coverage   99.89%   97.77%   -2.12%     
==========================================
  Files          18       18              
  Lines        2908     2971      +63     
==========================================
  Hits         2905     2905              
- Misses          2       65      +63     
  Partials        1        1              
Impacted Files Coverage Δ
carbon.go 81.25% <0.00%> (-18.75%) ⬇️
creator.go 85.50% <0.00%> (-14.50%) ⬇️
json.go 75.60% <0.00%> (-24.40%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MohammadGhodsian MohammadGhodsian deleted the add-time-struct-to-json branch July 24, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants