Don't Specify an ACL by Default (Fixes #110) #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ACLs in S3 predate IAM. They are also no longer recommended. Instead, users are encouraged to rely on IAM and Bucket Policies to manage access. Amazon is even going to start disabling ACLs on new buckets (see https://docs.aws.amazon.com/AmazonS3/latest/userguide/ensure-object-ownership.html).Users are also generally encouraged to set `BucketOwnerEnforced` on existing buckets to disable ACLs. When ACLs are disabled on a bucket, attempts to call `s3:PutObject` while specifying an `acl` parameter will cause an `AccessControlListNotSupported` error from AWS specifying that `The bucket does not allow ACLs`. This change updates the plugin so that there is no longer a default value for the ACL. The plugin will now only pass an ACL to `s3:PutObject` if one is explicitly specified by the user.
|
@bradrydzewski Any chance you might be able to help get some eyes on this change? |
devkimittal
approved these changes
Aug 30, 2023
|
@nhandler approved. Can you please rebase your code changes? |
@devkimittal The branch has been rebased. |
devkimittal
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ACLs in S3 predate IAM. They are also no longer recommended. Instead, users are encouraged to rely on IAM and Bucket Policies to manage access. Amazon is even going to start disabling ACLs on new buckets (see https://docs.aws.amazon.com/AmazonS3/latest/userguide/ensure-object-ownership.html).Users are also generally encouraged to set
BucketOwnerEnforcedon existing buckets to disable ACLs.When ACLs are disabled on a bucket, attempts to call
s3:PutObjectwhile specifying anaclparameter will cause anAccessControlListNotSupportederror from AWS specifying thatThe bucket does not allow ACLs.This change updates the plugin so that there is no longer a default value for the ACL. The plugin will now only pass an ACL to
s3:PutObjectif one is explicitly specified by the user.