fix: [CI-14134]: fix cross account access #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sapa96
approved these changes
Sep 19, 2024
Ompragash
approved these changes
Sep 19, 2024
|
@abhay084 CI Job execution link: https://harness.drone.io/drone-plugins/drone-s3/716/1/2 |
| @@ -460,6 +460,11 @@ func (p *Plugin) createS3Client() *s3.S3 { | |||
| log.Warn("AWS Key and/or Secret not provided (falling back to ec2 instance profile)") | |||
| } | |||
|
|
|||
| sess, err = session.NewSession(conf) | |||
There was a problem hiding this comment.
Please run go fmt. The indentation is off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes made: we were creating session with config which does not had the credential info, added a code change to update a session with new cred info. Which will help cross account to authenticate .
Test the change with OIDC flow also.