Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SetRelay #45

Closed
snorkel123 opened this issue Feb 9, 2015 · 8 comments
Closed

Add support for SetRelay #45

snorkel123 opened this issue Feb 9, 2015 · 8 comments

Comments

@snorkel123
Copy link
Contributor

No description provided.

@m4gr3d
Copy link
Member

m4gr3d commented Feb 9, 2015

@alextel69 I'm assuming you're referring to http://copter.ardupilot.com/wiki/mission-command-list/#do-set-relay?

@snorkel123
Copy link
Contributor Author

@ne0fhyk Yes, exactly

@m4gr3d
Copy link
Member

m4gr3d commented Feb 9, 2015

@alextel69 sounds good. Are you looking to use it as part of a mission?
If so a MissionItem implementation should suffice similar to what was done for DO_SET_SERVO: https://github.com/DroidPlanner/3DRServices/blob/master/AidlLib/src/com/o3dr/services/android/lib/drone/mission/item/command/SetServo.java

@snorkel123
Copy link
Contributor Author

@ne0fhyk I need both mission and nonmission control. I believe adding SetRelay is a better solution then creating the class in my app

@m4gr3d
Copy link
Member

m4gr3d commented Feb 10, 2015

@alextel69 SET_RELAY mission item support has been added in version 1.2.5.beta.

@m4gr3d
Copy link
Member

m4gr3d commented Feb 10, 2015

Javadoc for the SetRelay mission item: https://droidplanner.github.io/3DRServices/javadoc/

@snorkel123
Copy link
Contributor Author

@ne0fhyk Amazing!
Only nonmission control left. Possible option is to get MavLink message from SetRelayImpl, then send it as a raw message. But it won't be a good design anyway. Waiting for command addition to drone class.

@m4gr3d
Copy link
Member

m4gr3d commented Feb 12, 2015

@alextel69 the nonmission SET_RELAY control was added in version 1.2.6.beta.

Given that function has no defined interaction model yet, it has been placed in the ExperimentalApi section of the client library: https://github.com/DroidPlanner/3DRServices/blob/87ea75bdd3aab4ac7a039e229686955158121261/ClientLib/mobile/src/main/java/com/o3dr/android/client/apis/drone/ExperimentalApi.java.

To make use of the new api, you'll need version 2.2.11 of the client library: https://bintray.com/fredia/maven/3dr-services-lib/2.2.11/view

@m4gr3d m4gr3d closed this as completed Feb 12, 2015
m4gr3d pushed a commit that referenced this issue Feb 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants