Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build #500

Merged
merged 5 commits into from
Jul 18, 2023
Merged

Fix build #500

merged 5 commits into from
Jul 18, 2023

Conversation

devPalacio
Copy link
Contributor

@devPalacio devPalacio commented Jul 17, 2023

This PR fixes issues our users were having running ./gradlew build
Fixes:

  • Javadoc task failing due to invalid flag
  • :test task failing
  • outdated mockito version
  • redundant gradle wrapper in examples directory
  • vague python exit code 1 error when trying to build without submodules initialized

@devPalacio devPalacio requested a review from jonamireh July 17, 2023 21:41
@devPalacio devPalacio marked this pull request as ready for review July 17, 2023 21:43
@devPalacio devPalacio requested a review from wdziemia July 17, 2023 21:43
@devPalacio devPalacio self-assigned this Jul 17, 2023
@devPalacio devPalacio added the bug label Jul 17, 2023
@devPalacio devPalacio merged commit 4960858 into main Jul 18, 2023
@devPalacio devPalacio deleted the fix-build branch July 18, 2023 14:23
devPalacio added a commit that referenced this pull request Oct 3, 2023
* fix javadoc task failing

* Bump mockito, delete unneeded wrapper, get build to pass

* add check for stone submodule for more clear error message

* revert setting kotlin version

* Update CHANGELOG.md

---------

Co-authored-by: Jay Palacio <jpalacio@dropbox.com>
(cherry picked from commit 4960858)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants