Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to jakarta #501

Merged
merged 6 commits into from
Aug 4, 2023
Merged

move to jakarta #501

merged 6 commits into from
Aug 4, 2023

Conversation

devPalacio
Copy link
Contributor

@devPalacio devPalacio commented Jul 17, 2023

This PR moves us to the Jakarta Servlet namespace to allow users of Spring boot V3 to consume our SDK.
I used the built in migration tool in IntelliJ to do the bulk of the work.
I also had to bump the jetty servlet version for compatibility in our examples and tests.

Fixes #495

@devPalacio devPalacio marked this pull request as ready for review July 17, 2023 21:40
@devPalacio devPalacio self-assigned this Jul 17, 2023
@devPalacio devPalacio changed the base branch from fix-build to main July 17, 2023 21:51
@devPalacio devPalacio requested a review from jonamireh July 17, 2023 21:51
@devPalacio devPalacio changed the base branch from main to fix-build July 17, 2023 21:53
@devPalacio devPalacio linked an issue Jul 17, 2023 that may be closed by this pull request
@devPalacio devPalacio requested a review from wdziemia July 18, 2023 14:08
Base automatically changed from fix-build to main July 18, 2023 14:23
@devPalacio devPalacio requested a review from joshafeinberg July 18, 2023 19:37
Copy link
Contributor

@wdziemia wdziemia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spoke w/ Jay - will incorporate note about Jakarta upgrade which will be a breaking change. since DbxSessionStore constructor signature changes.

@devPalacio devPalacio merged commit 42c4988 into main Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jakarta (Servlet API)
2 participants