-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed :type: to :class: in dropbox.file_properties #252
Conversation
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
=======================================
Coverage 46.98% 46.98%
=======================================
Files 32 32
Lines 77334 77334
Branches 6370 6370
=======================================
Hits 36332 36332
Misses 40951 40951
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Thanks for submitting this. @rogebrd can take a look, but this may need to actually be changed in the spec itself, or maybe this is something for the generator to handle. |
Pleasure! No worries, I just wanted to open it so that it’s documented but feel free to close it if the cause is somewhere else. |
Sorry for the delay on the response. This will require an internal change to the spec itself so I have opened a diff on our internal repo. Once that is approved, this change will come in the next spec update. I will leave this open for tracking until then! |
Ok perfect, no worries thanks for the update! |
- Rather than emitting the doc directly run through process_doc - Fix for ([PR #252](dropbox/dropbox-sdk-python#252))
Hey, I put out a fix to Stone to fix this issue. We have an upcoming task to upgrade stone past 1.X which this PR will be blocked on that completing. Hopefully this isn't causing any immediate issues for you! |
Hi, thanks for the update. No, no problems here, I'll close the PR then. |
* Update Python Backend Docstring - Rather than emitting the doc directly run through process_doc - Fix for ([PR #252](dropbox/dropbox-sdk-python#252)) * Update CI to run entirely python3
Changed :type: to :class:, which gets correctly rendered by readthedocs.
Before:
After:
Checklist
General Contributing
Is This a Code Change?
Validation
tox
pass?