Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed :type: to :class: in dropbox.file_properties #252

Closed
wants to merge 1 commit into from
Closed

Changed :type: to :class: in dropbox.file_properties #252

wants to merge 1 commit into from

Conversation

BastianZim
Copy link
Contributor

@BastianZim BastianZim commented Sep 27, 2020

Changed :type: to :class:, which gets correctly rendered by readthedocs.

Before:
Screenshot 2020-09-27 at 19 49 46

After:
Screenshot 2020-09-27 at 19 49 22

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • SDK Code Change
  • Example/Test Code Change

Validation

  • Does tox pass?
  • Do the tests pass?

@BastianZim BastianZim changed the title Changed :type: to :class: Changed :type: to :class: in dropbox.file_properties Sep 27, 2020
@codecov
Copy link

codecov bot commented Sep 27, 2020

Codecov Report

Merging #252 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #252   +/-   ##
=======================================
  Coverage   46.98%   46.98%           
=======================================
  Files          32       32           
  Lines       77334    77334           
  Branches     6370     6370           
=======================================
  Hits        36332    36332           
  Misses      40951    40951           
  Partials       51       51           
Flag Coverage Δ
#unit 46.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dropbox/file_properties.py 48.98% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6105d87...c586d21. Read the comment docs.

@greg-db
Copy link
Contributor

greg-db commented Sep 28, 2020

Thanks for submitting this.

@rogebrd can take a look, but this may need to actually be changed in the spec itself, or maybe this is something for the generator to handle.

@greg-db greg-db requested a review from rogebrd September 28, 2020 17:15
@BastianZim
Copy link
Contributor Author

Pleasure!

No worries, I just wanted to open it so that it’s documented but feel free to close it if the cause is somewhere else.

@rogebrd
Copy link
Contributor

rogebrd commented Oct 6, 2020

Sorry for the delay on the response. This will require an internal change to the spec itself so I have opened a diff on our internal repo. Once that is approved, this change will come in the next spec update. I will leave this open for tracking until then!

@BastianZim
Copy link
Contributor Author

Ok perfect, no worries thanks for the update!

rogebrd added a commit to dropbox/stone that referenced this pull request Oct 7, 2020
- Rather than emitting the doc directly run through process_doc
- Fix for ([PR #252](dropbox/dropbox-sdk-python#252))
@rogebrd
Copy link
Contributor

rogebrd commented Oct 7, 2020

Hey, I put out a fix to Stone to fix this issue. We have an upcoming task to upgrade stone past 1.X which this PR will be blocked on that completing. Hopefully this isn't causing any immediate issues for you!

@BastianZim
Copy link
Contributor Author

Hi, thanks for the update. No, no problems here, I'll close the PR then.

@BastianZim BastianZim closed this Oct 8, 2020
rogebrd added a commit to dropbox/stone that referenced this pull request Oct 8, 2020
* Update Python Backend Docstring

- Rather than emitting the doc directly run through process_doc
- Fix for ([PR #252](dropbox/dropbox-sdk-python#252))

* Update CI to run entirely python3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants