Remove use of http_uri:encode #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Oh cool thank you for looking into this! I remember trying something a while back and it did not encode correctly which is why I left it. Things may be different now, that was a few years ago. I'll verify it works sometime soon. Thanks again! |
|
Sorry it wasn't quicker, I just got around to verifying |
|
For anyone stumbling upon this PR: |
ns-codereview
pushed a commit
to couchbase/ns_server
that referenced
this pull request
Feb 14, 2024
This copies dropbox/esaml#6 to remove the use of the deprecated http_uri module and replace it with the recommended uri_string module. Also copies dropbox/esaml#7 to get rid of extra uri encoding. Change-Id: I57f978321ba04556e9047838725a6fd1de0b0c1c Reviewed-on: https://review.couchbase.org/c/ns_server/+/204526 Tested-by: Build Bot <build@couchbase.com> Well-Formed: Build Bot <build@couchbase.com> Tested-by: Steve Watanabe <steve.watanabe@couchbase.com> Reviewed-by: Ben Huddleston <ben.huddleston@couchbase.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This removes the use of the deprecated
http_urimodule and replaces it with the recommenduri_stringmodule.uri_stringhas been recommended since OTP 21, andhttp_uriwill be removed completely in OTP 26.Changes
This uses
uri_string:compose_query/1to build up the query parameters (instead of manually concatenating a binary). It relies on the the function's behavior that will put keys and values throughuri_string:quote()(so we must be sure we don't double-encode).In testing several XML payloads run through
base64:encode_to_string(zlib:zip(Req))and then comparing the results of bothhttp_uri:encode()vs.uri_string:quote(), my results consistently matched. If there is a known difference between the output of the two functions?Unknowns
uri_string:normalize()on theRelayStatealso doing percent encoding?"username"parameter to theQueryList?