WIP: Add Explore Database to CTAS/CVAS visualization flow #19
Conversation
WARNING: Prefer TypeScriptIt looks like your PR contains new |
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
==========================================
+ Coverage 65.81% 70.84% +5.03%
==========================================
Files 594 404 -190
Lines 31319 13056 -18263
Branches 3206 3206
==========================================
- Hits 20613 9250 -11363
+ Misses 10525 3690 -6835
+ Partials 181 116 -65
Continue to review full report at Codecov.
|
JasonD28
force-pushed
the
explore_db_visual
branch
from
eb93e60
to
a9fec93
Compare
| @@ -187,6 +187,10 @@ def allows_cost_estimate(self) -> bool: | |||
| and cost_estimate_enabled | |||
| ) | |||
|
|
|||
| @property | |||
| def explore_database_visualization_id(self) -> int: | |||
There was a problem hiding this comment.
lets keep it simple, just do explore_database_id
also change code https://github.com/apache/incubator-superset/blob/c7618ee54b62760ac5f738996379de0dcd5e326e/superset/views/database/views.py#L190 here to use this property
| @@ -135,6 +135,7 @@ class DatabaseRestApi(DatabaseMixin, BaseSupersetModelRestApi): | |||
| "allow_csv_upload", | |||
| "allows_subquery", | |||
| "allows_cost_estimate", | |||
| "explore_database_visualization_id", | |||
There was a problem hiding this comment.
let's keep it simple, just use explore_database_id
| @@ -238,7 +238,7 @@ export default class ResultSet extends React.PureComponent { | |||
| <ExploreCtasResultsButton | |||
| table={tmpTable} | |||
| schema={tmpSchema} | |||
| dbId={query.dbId} | |||
| dbId={this.props.database.explore_database_visualization_id} | |||
There was a problem hiding this comment.
I was thinking about doing that in the api endpoint, however this is even cleaner approach
Add new core modules from incubator-superset
* fix: show only necessary ticks on log scale and add storybook * fix: storybook path
Ran following commands: ``` brew install pngquant pngquant --quality=65-80 ./packages/**/*.png --ext .png --force ```
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION