Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cli.py to work with java sdk #310

Merged
merged 4 commits into from
Jul 20, 2023
Merged

Update cli.py to work with java sdk #310

merged 4 commits into from
Jul 20, 2023

Conversation

devPalacio
Copy link
Contributor

@devPalacio devPalacio commented Jul 20, 2023 •
edited
Loading

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • Code Change
  • Example/Test Code Change

Validation

  • Have you ran tox?
  • Do the tests pass?

@codecov
Copy link

codecov bot commented Jul 20, 2023 •
edited
Loading

Codecov Report

Merging #310 (d8ef0f6) into main (af56116) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head d8ef0f6 differs from pull request most recent head 6a282dc. Consider uploading reports for the commit 6a282dc to get more accurate results

@@            Coverage Diff             @@
##             main     #310      +/-   ##
==========================================
- Coverage   51.95%   51.94%   -0.01%     
==========================================
  Files          37       37              
  Lines        8463     8464       +1     
  Branches     1811     1811              
==========================================
  Hits         4397     4397              
- Misses       3749     3750       +1     
  Partials      317      317
Flag Coverage Δ
unit 51.94% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stone/cli.py 0.00% <0.00%> (ø)

@devPalacio devPalacio requested a review from julianlocke July 20, 2023 12:48
@devPalacio devPalacio self-assigned this Jul 20, 2023
@devPalacio devPalacio mentioned this pull request Jul 20, 2023
Merged
julianlocke
julianlocke approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@julianlocke julianlocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well remove name if we're not really going to use it, otherwise looks good!

@devPalacio
Update cli.py
6a282dc 
remove unnecessary 'name' parameter from _load_module
@julianlocke julianlocke merged commit 02feff3 into main Jul 20, 2023
@julianlocke julianlocke deleted the fix-java-sdk branch July 20, 2023 15:59
julianlocke added a commit that referenced this pull request Jul 20, 2023
@julianlocke @devPalacio
Swifty dropbox beta imp removed (#313)
f7c1aa3 
* Fix ci: pin linux, pin flake8, ignore type error, fix mypy (#308)

* Replace uses of deprecated imp with importlib (#307)

* Update cli.py to work with java sdk (#310)

---------

Co-authored-by: Jay <jaypalacio@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianlocke julianlocke julianlocke approved these changes

Assignees

@devPalacio devPalacio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devPalacio @julianlocke