Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make custom annotation generation deterministic #326

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

vidit2606
Copy link
Contributor

@vidit2606 vidit2606 commented Mar 27, 2024

Changing code which generates python datatypes for stone. This would make custom_annotation related generated code to be deterministic in nature (alphabetic order)

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • [ X] Code Change
  • Example/Test Code Change

Validation

  • Have you ran tox?
  • Do the tests pass?

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 51.93%. Comparing base (e242f7f) to head (a4dff04).

Files Patch % Lines
stone/cli.py 0.00% 2 Missing ⚠️
stone/backends/python_types.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
- Coverage   51.93%   51.93%   -0.01%     
==========================================
  Files          37       37              
  Lines        8415     8419       +4     
  Branches     1807     1809       +2     
==========================================
+ Hits         4370     4372       +2     
- Misses       3729     3731       +2     
  Partials      316      316              
Flag Coverage Δ
unit 51.93% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vidit2606 vidit2606 removed the request for review from sderickson March 27, 2024 21:39
Copy link
Contributor

@julianlocke julianlocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added untested lines are just imports, so I'm not worries about the code cove warnings.

@julianlocke julianlocke merged commit fbc20bb into main Mar 27, 2024
11 of 12 checks passed
@julianlocke julianlocke deleted the prs/vidit2606/viditb_custom_annotation_fix branch March 27, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants